Commit dc6dc3e7 authored by Masahiro Yamada's avatar Masahiro Yamada
Browse files

kbuild: do not remove empty *.symtypes explicitly 



Presumably, 'test -s $@ || rm -f $@' intends to remove the output when
the genksyms command fails.

It is unneeded because .DELETE_ON_ERROR automatically removes the output
on failure.

Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Reviewed-by: default avatarNicolas Schier <nicolas@fjasle.eu>
parent f43e31d5

scripts/Makefile.build

+2 −6
Original line number Diff line number Diff line
@@ -135,9 +135,7 @@ genksyms = scripts/genksyms/genksyms \ 
cmd_gensymtypes_c = $(CPP) -D__GENKSYMS__ $(c_flags) $< | $(genksyms)



quiet_cmd_cc_symtypes_c = SYM $(quiet_modtag) $@

cmd_cc_symtypes_c =                                                         \

    $(call cmd_gensymtypes_c,true,$@) >/dev/null;                           \

    test -s $@ || rm -f $@

      cmd_cc_symtypes_c = $(call cmd_gensymtypes_c,true,$@) >/dev/null



$(obj)/%.symtypes : $(src)/%.c FORCE

	$(call cmd,cc_symtypes_c)
@@ -348,9 +346,7 @@ cmd_gensymtypes_S = \ 
    $(CPP) -D__GENKSYMS__ $(c_flags) -xc - | $(genksyms)



quiet_cmd_cc_symtypes_S = SYM $(quiet_modtag) $@

cmd_cc_symtypes_S =                                                         \

    $(call cmd_gensymtypes_S,true,$@) >/dev/null;                           \

    test -s $@ || rm -f $@

      cmd_cc_symtypes_S = $(call cmd_gensymtypes_S,true,$@) >/dev/null



$(obj)/%.symtypes : $(src)/%.S FORCE

	$(call cmd,cc_symtypes_S)