Commit dc256418 authored by Zhiqiang Liu's avatar Zhiqiang Liu Committed by Dave Chinner
Browse files

xfs: do not need to check return value of xlog_kvmalloc() 



In xfs_attri_log_nameval_alloc(), xlog_kvmalloc() is called
to alloc memory, which will always return
successfully, so we donot need to check return value.

Reviewed-by: default avatarEric Sandeen <sandeen@redhat.com>
Signed-off-by: default avatarZhiqiang Liu <liuzhiqiang26@huawei.com>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
parent 42b7cc11

fs/xfs/xfs_attr_item.c

+0 −6
Original line number Diff line number Diff line
@@ -86,8 +86,6 @@ xfs_attri_log_nameval_alloc( 
	 */

	nv = xlog_kvmalloc(sizeof(struct xfs_attri_log_nameval) +

					name_len + value_len);

	if (!nv)

		return nv;



	nv->name.i_addr = nv + 1;

	nv->name.i_len = name_len;
@@ -441,8 +439,6 @@ xfs_attr_create_intent( 
		attr->xattri_nameval = xfs_attri_log_nameval_alloc(args->name,

				args->namelen, args->value, args->valuelen);

	}

	if (!attr->xattri_nameval)

		return ERR_PTR(-ENOMEM);



	attrip = xfs_attri_init(mp, attr->xattri_nameval);

	xfs_trans_add_item(tp, &attrip->attri_item);
@@ -762,8 +758,6 @@ xlog_recover_attri_commit_pass2( 
	nv = xfs_attri_log_nameval_alloc(attr_name,

			attri_formatp->alfi_name_len, attr_value,

			attri_formatp->alfi_value_len);

	if (!nv)

		return -ENOMEM;



	attrip = xfs_attri_init(mp, nv);

	error = xfs_attri_copy_format(&item->ri_buf[0], &attrip->attri_format);