Commit dc18a4c7 authored by Yang Yingliang's avatar Yang Yingliang Committed by Greg Kroah-Hartman
Browse files

usb: typec: wusb3801: fix fwnode refcount leak in wusb3801_probe() 



I got the following report while doing fault injection test:

  OF: ERROR: memory leak, expected refcount 1 instead of 4,
  of_node_get()/of_node_put() unbalanced - destroy cset entry:
  attach overlay node /i2c/tcpc@60/connector

If wusb3801_hw_init() fails, fwnode_handle_put() needs be called to
avoid refcount leak.

Fixes: d016cbe4 ("usb: typec: Support the WUSB3801 port controller")
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221203071027.3808308-1-yangyingliang@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c35ca10f

drivers/usb/typec/wusb3801.c

+1 −1
Original line number Diff line number Diff line
@@ -364,7 +364,7 @@ static int wusb3801_probe(struct i2c_client *client) 
	/* Initialize the hardware with the devicetree settings. */

	ret = wusb3801_hw_init(wusb3801);

	if (ret)

		return ret;

		goto err_put_connector;



	wusb3801->cap.revision		= USB_TYPEC_REV_1_2;

	wusb3801->cap.accessory[0]	= TYPEC_ACCESSORY_AUDIO;