Commit dbd3be51 authored by Su Hui's avatar Su Hui Committed by Wen Zhiwei
Browse files

ASoC: codecs: avoid possible garbage value in peb2466_reg_read() 

stable inclusion
from stable-v6.6.52
commit 6ec7cbc7f57866388f03bf75eb47e6f515debc1c
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IAYXOD

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=6ec7cbc7f57866388f03bf75eb47e6f515debc1c



--------------------------------

[ Upstream commit 38cc0334baabc5baf08a1db753de521e016c0432 ]

Clang static checker (scan-build) warning:
sound/soc/codecs/peb2466.c:232:8:
Assigned value is garbage or undefined [core.uninitialized.Assign]
  232 |                 *val = tmp;
      |                      ^ ~~~

When peb2466_read_byte() fails, 'tmp' will have a garbage value.
Add a judgemnet to avoid this problem.

Fixes: 227f609c ("ASoC: codecs: Add support for the Infineon PEB2466 codec")
Signed-off-by: default avatarSu Hui <suhui@nfschina.com>
Link: https://patch.msgid.link/20240911115448.277828-1-suhui@nfschina.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarWen Zhiwei <wenzhiwei@kylinos.cn>
parent b75a8440

sound/soc/codecs/peb2466.c

+2 −1
Original line number Diff line number Diff line
@@ -229,6 +229,7 @@ static int peb2466_reg_read(void *context, unsigned int reg, unsigned int *val) 
	case PEB2466_CMD_XOP:

	case PEB2466_CMD_SOP:

		ret = peb2466_read_byte(peb2466, reg, &tmp);

		if (!ret)

			*val = tmp;

		break;

	default: