Commit dbc77f31 authored by Darrick J. Wong's avatar Darrick J. Wong
Browse files

vfs: only allow FSSETXATTR to set DAX flag on files and dirs 



The DAX flag only applies to files and directories, so don't let it get
set for other types of files.

Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
parent ca29be75

fs/inode.c

+8 −0
Original line number Diff line number Diff line
@@ -2239,6 +2239,14 @@ int vfs_ioc_fssetxattr_check(struct inode *inode, const struct fsxattr *old_fa, 
	    !S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode))

		return -EINVAL;



	/*

	 * It is only valid to set the DAX flag on regular files and

	 * directories on filesystems.

	 */

	if ((fa->fsx_xflags & FS_XFLAG_DAX) &&

	    !(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode)))

		return -EINVAL;



	/* Extent size hints of zero turn off the flags. */

	if (fa->fsx_extsize == 0)

		fa->fsx_xflags &= ~(FS_XFLAG_EXTSIZE | FS_XFLAG_EXTSZINHERIT);