Commit db9c2907 authored by Zheng Wang's avatar Zheng Wang Committed by Jialin Zhang
Browse files

Bluetooth: btsdio: fix use after free bug in btsdio_remove due to race condition 

mainline inclusion
from mainline-v6.3-rc7
commit 73f7b171
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/I6UW68
CVE: CVE-2023-1989

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=73f7b171b7c09139eb3c6a5677c200dc1be5f318



---------------------------

In btsdio_probe, the data->work is bound with btsdio_work. It will be
started in btsdio_send_frame.

If the btsdio_remove runs with a unfinished work, there may be a race
condition that hdev is freed but used in btsdio_work. Fix it by
canceling the work before do cleanup in btsdio_remove.

Signed-off-by: default avatarZheng Wang <zyytlz.wz@163.com>
Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: default avatarLiu Jian <liujian56@huawei.com>
Reviewed-by: default avatarYue Haibing <yuehaibing@huawei.com>
Reviewed-by: default avatarWang Weiyang <wangweiyang2@huawei.com>
Signed-off-by: default avatarJialin Zhang <zhangjialin11@huawei.com>
parent ed2d922a

drivers/bluetooth/btsdio.c

+1 −0
Original line number Diff line number Diff line
@@ -355,6 +355,7 @@ static void btsdio_remove(struct sdio_func *func) 
	if (!data)

		return;



	cancel_work_sync(&data->work);

	hdev = data->hdev;



	sdio_set_drvdata(func, NULL);