Commit db301cff authored by Vinay Belgaumkar's avatar Vinay Belgaumkar Committed by John Harrison
Browse files

drm/i915/guc/slpc: Remove BUG_ON in guc_submission_disable 



The assumption when it was added was that GT would not be
holding any gt_pm references. However, uc_init is called
from gt_init_hw, which holds a forcewake ref. If SLPC
enable fails, we will still be holding this ref, which will
result in the BUG_ON.

Reviewed-by: default avatarMatthew Brost <matthew.brost@intel.com>
Signed-off-by: default avatarVinay Belgaumkar <vinay.belgaumkar@intel.com>
Signed-off-by: default avatarJohn Harrison <John.C.Harrison@Intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210730202119.23810-7-vinay.belgaumkar@intel.com
parent 63c0eb30

drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c

+0 −4
Original line number Diff line number Diff line
@@ -2536,10 +2536,6 @@ void intel_guc_submission_enable(struct intel_guc *guc) 


void intel_guc_submission_disable(struct intel_guc *guc)

{

	struct intel_gt *gt = guc_to_gt(guc);



	GEM_BUG_ON(gt->awake); /* GT should be parked first */



	/* Note: By the time we're here, GuC may have already been reset */

}