Commit dadf33c9 authored by Dan Carpenter's avatar Dan Carpenter Committed by Pablo Neira Ayuso
Browse files

netfilter: nftables: fix a warning message in nf_tables_commit_audit_collect() 



The first argument of a WARN_ONCE() is a condition.  This WARN_ONCE()
will only print the table name, and is potentially problematic if the
table name has a %s in it.

Fixes: c520292f ("audit: log nftables configuration change events once per table")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarPaul Moore <paul@paul-moore.com>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent daf47a7c

net/netfilter/nf_tables_api.c

+1 −1
Original line number Diff line number Diff line
@@ -7978,7 +7978,7 @@ static void nf_tables_commit_audit_collect(struct list_head *adl, 
		if (adp->table == table)

			goto found;

	}

	WARN_ONCE("table=%s not expected in commit list", table->name);

	WARN_ONCE(1, "table=%s not expected in commit list", table->name);

	return;

found:

	adp->entries++;