Commit dadc5b86 authored by Yuanjun Gong's avatar Yuanjun Gong Committed by Jakub Kicinski
Browse files

net: dsa: fix value check in bcm_sf2_sw_probe() 



in bcm_sf2_sw_probe(), check the return value of clk_prepare_enable()
and return the error code if clk_prepare_enable() returns an
unexpected value.

Fixes: e9ec5c3b ("net: dsa: bcm_sf2: request and handle clocks")
Signed-off-by: default avatarYuanjun Gong <ruc_gongyuanjun@163.com>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/20230726170506.16547-1-ruc_gongyuanjun@163.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 4d50e500

drivers/net/dsa/bcm_sf2.c

+6 −2
Original line number Diff line number Diff line
@@ -1436,7 +1436,9 @@ static int bcm_sf2_sw_probe(struct platform_device *pdev) 
	if (IS_ERR(priv->clk))

		return PTR_ERR(priv->clk);



	clk_prepare_enable(priv->clk);

	ret = clk_prepare_enable(priv->clk);

	if (ret)

		return ret;



	priv->clk_mdiv = devm_clk_get_optional(&pdev->dev, "sw_switch_mdiv");

	if (IS_ERR(priv->clk_mdiv)) {
@@ -1444,7 +1446,9 @@ static int bcm_sf2_sw_probe(struct platform_device *pdev) 
		goto out_clk;

	}



	clk_prepare_enable(priv->clk_mdiv);

	ret = clk_prepare_enable(priv->clk_mdiv);

	if (ret)

		goto out_clk;



	ret = bcm_sf2_sw_rst(priv);

	if (ret) {