Commit dad17303 authored by Oswald Buddenhagen's avatar Oswald Buddenhagen Committed by Takashi Iwai
Browse files

ALSA: emu10k1: don't stop DSP in _snd_emu10k1_{,audigy_}init_efx() 



These functions don't actually touch the DSP until they poke the code
into it, at which point it's temporarily stopped anyway. And fx8010.dbg
is already zero anyway.

Signed-off-by: default avatarOswald Buddenhagen <oswald.buddenhagen@gmx.de>
Link: https://lore.kernel.org/r/20230422161021.1144004-2-oswald.buddenhagen@gmx.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 37505289

sound/pci/emu10k1/emufx.c

+0 −6
Original line number Diff line number Diff line
@@ -1259,9 +1259,6 @@ static int _snd_emu10k1_audigy_init_efx(struct snd_emu10k1 *emu) 
	gpr_map[gpr++] = 0x0000ffff;

	bit_shifter16 = gpr;



	/* stop FX processor */

	snd_emu10k1_ptr_write(emu, A_DBG, 0, (emu->fx8010.dbg = 0) | A_DBG_SINGLE_STEP);



#if 1

	/* PCM front Playback Volume (independent from stereo mix)

	 * playback = 0 + ( gpr * FXBUS_PCM_LEFT_FRONT >> 31)
@@ -1903,9 +1900,6 @@ static int _snd_emu10k1_init_efx(struct snd_emu10k1 *emu) 
	tmp = 0x88;	/* we need 4 temporary GPR */

	/* from 0x8c to 0xff is the area for tone control */



	/* stop FX processor */

	snd_emu10k1_ptr_write(emu, DBG, 0, (emu->fx8010.dbg = 0) | EMU10K1_DBG_SINGLE_STEP);



	/*

	 *  Process FX Buses

	 */