Commit dac78378 authored by Ruan Jinjie's avatar Ruan Jinjie Committed by Alexandre Belloni
Browse files

rtc: tps65910: Remove redundant dev_warn() and do not check for 0 return after... 


rtc: tps65910: Remove redundant dev_warn() and do not check for 0 return after calling platform_get_irq()

It is not possible for platform_get_irq() to return 0. Use the
return value from platform_get_irq().

And there is no need to call the dev_warn() function directly to print
a custom message when handling an error from platform_get_irq()
function as it is going to display an appropriate error message
in case of a failure.

Signed-off-by: default avatarRuan Jinjie <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20230803080713.4061782-3-ruanjinjie@huawei.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 4d349a57

drivers/rtc/rtc-tps65910.c

+2 −5
Original line number Diff line number Diff line
@@ -406,11 +406,8 @@ static int tps65910_rtc_probe(struct platform_device *pdev) 
	platform_set_drvdata(pdev, tps_rtc);



	irq  = platform_get_irq(pdev, 0);

	if (irq <= 0) {

		dev_warn(&pdev->dev, "Wake up is not possible as irq = %d\n",

			irq);

		return -ENXIO;

	}

	if (irq < 0)

		return irq;



	ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,

		tps65910_rtc_interrupt, IRQF_TRIGGER_LOW,