Commit dac348e9 authored by Josef Bacik's avatar Josef Bacik Committed by David Sterba
Browse files

btrfs: stop running all delayed refs during snapshot 



This was added in commit 361048f5 ("Btrfs: fix full backref problem
when inserting shared block reference") to address a problem where we
hit the following BUG_ON() in alloc_reserved_tree_block

        if (node->type == BTRFS_SHARED_BLOCK_REF_KEY) {
                BUG_ON(!(flags & BTRFS_BLOCK_FLAG_FULL_BACKREF));

However this BUG_ON() is bogus, and was removed by previous commit:

  btrfs: remove bogus BUG_ON in alloc_reserved_tree_block

We no longer need to run delayed refs because of this, and can remove
this flushing here.

Signed-off-by: default avatarJosef Bacik <josef@toxicpanda.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent b7774425

fs/btrfs/transaction.c

+0 −6
Original line number Diff line number Diff line
@@ -1749,12 +1749,6 @@ static noinline int create_pending_snapshot(struct btrfs_trans_handle *trans, 
		}

	}



	ret = btrfs_run_delayed_refs(trans, (unsigned long)-1);

	if (ret) {

		btrfs_abort_transaction(trans, ret);

		goto fail;

	}



fail:

	pending->error = ret;

dir_item_existed: