Commit daaecb41 authored Jan 11, 2021 by Saurav Kashyap Committed by Martin K. Petersen Jan 13, 2021

scsi: qla2xxx: Move some messages from debug to normal log level

This change will aid in debugging issues arising because of dropped frame,
DIF errors, queue full etc where debug level is not set.

Link: https://lore.kernel.org/r/20210111093134.1206-4-njavali@marvell.com

Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 307862e6

drivers/scsi/qla2xxx/qla_init.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -347,9 +347,9 @@ qla2x00_async_login(struct scsi_qla_host vha, fc_port_t fcport,
		if (NVME_TARGET(vha->hw, fcport))
		lio->u.logio.flags \|= SRB_LOGIN_SKIP_PRLI;

		ql_dbg(ql_dbg_disc, vha, 0x2072,
		"Async-login - %8phC hdl=%x, loopid=%x portid=%02x%02x%02x "
		"retries=%d.\n", fcport->port_name, sp->handle, fcport->loop_id,
		ql_log(ql_log_warn, vha, 0x2072,
		"Async-login - %8phC hdl=%x, loopid=%x portid=%02x%02x%02x retries=%d.\n",
		fcport->port_name, sp->handle, fcport->loop_id,
		fcport->d_id.b.domain, fcport->d_id.b.area, fcport->d_id.b.al_pa,
		fcport->login_retry);

drivers/scsi/qla2xxx/qla_isr.c

+25 −27

Original line number	Diff line number	Diff line
		@@ -1455,7 +1455,7 @@ qla2x00_async_event(scsi_qla_host_t vha, struct rsp_que rsp, uint16_t *mb)
		if (ha->flags.npiv_supported && vha->vp_idx != (mb[3] & 0xff))
		break;

		ql_dbg(ql_dbg_async, vha, 0x5013,
		ql_log(ql_log_warn, vha, 0x5013,
		"RSCN database changed -- %04x %04x %04x.\n",
		mb[1], mb[2], mb[3]);

		@@ -2221,7 +2221,7 @@ qla24xx_logio_entry(scsi_qla_host_t vha, struct req_que req,
		break;
		}

		ql_dbg(ql_dbg_async, sp->vha, 0x5037,
		ql_log(ql_log_warn, sp->vha, 0x5037,
		"Async-%s failed: handle=%x pid=%06x wwpn=%8phC comp_status=%x iop0=%x iop1=%x\n",
		type, sp->handle, fcport->d_id.b24, fcport->port_name,
		le16_to_cpu(logio->comp_status),
		@@ -2389,7 +2389,7 @@ static void qla24xx_nvme_iocb_entry(scsi_qla_host_t vha, struct req_que req,

		tgt_xfer_len = be32_to_cpu(rsp_iu->xfrd_len);
		if (fd->transferred_length != tgt_xfer_len) {
		ql_dbg(ql_dbg_io, fcport->vha, 0x3079,
		ql_log(ql_log_warn, fcport->vha, 0x3079,
		"Dropped frame(s) detected (sent/rcvd=%u/%u).\n",
		tgt_xfer_len, fd->transferred_length);
		logit = 1;
		@@ -3112,7 +3112,7 @@ qla2x00_status_entry(scsi_qla_host_t vha, struct rsp_que rsp, void *pkt)
		scsi_set_resid(cp, resid);
		if (scsi_status & SS_RESIDUAL_UNDER) {
		if (IS_FWI2_CAPABLE(ha) && fw_resid_len != resid_len) {
		ql_dbg(ql_dbg_io, fcport->vha, 0x301d,
		ql_log(ql_log_warn, fcport->vha, 0x301d,
		"Dropped frame(s) detected (0x%x of 0x%x bytes).\n",
		resid, scsi_bufflen(cp));

		@@ -3139,7 +3139,7 @@ qla2x00_status_entry(scsi_qla_host_t vha, struct rsp_que rsp, void *pkt)
		* task not completed.
		*/

		ql_dbg(ql_dbg_io, fcport->vha, 0x301f,
		ql_log(ql_log_warn, fcport->vha, 0x301f,
		"Dropped frame(s) detected (0x%x of 0x%x bytes).\n",
		resid, scsi_bufflen(cp));

		@@ -3257,10 +3257,8 @@ qla2x00_status_entry(scsi_qla_host_t vha, struct rsp_que rsp, void *pkt)

		out:
		if (logit)
		ql_dbg(ql_dbg_io, fcport->vha, 0x3022,
		"FCP command status: 0x%x-0x%x (0x%x) nexus=%ld:%d:%llu "
		"portid=%02x%02x%02x oxid=0x%x cdb=%10phN len=0x%x "
		"rsp_info=0x%x resid=0x%x fw_resid=0x%x sp=%p cp=%p.\n",
		ql_log(ql_log_warn, fcport->vha, 0x3022,
		"FCP command status: 0x%x-0x%x (0x%x) nexus=%ld:%d:%llu portid=%02x%02x%02x oxid=0x%x cdb=%10phN len=0x%x rsp_info=0x%x resid=0x%x fw_resid=0x%x sp=%p cp=%p.\n",
		comp_status, scsi_status, res, vha->host_no,
		cp->device->id, cp->device->lun, fcport->d_id.b.domain,
		fcport->d_id.b.area, fcport->d_id.b.al_pa, ox_id,