Commit da9db711 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

cxl: Fix an error message 



'rc' is known to be 0 here.
Initialize 'rc' with the expected error code before using it.

While at it, avoid the affectation of 'rc' in a 'if' to make things more
obvious and linux style.

Fixes: f204e0b8 ("cxl: Driver code for powernv PCIe based cards for userspace access")
Acked-by: default avatarAndrew Donnellan <ajd@linux.ibm.com>
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/fa2b2c9c72335ab4c3d5e6a33415e7f020b1d51b.1620243401.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e4e05016

drivers/misc/cxl/file.c

+3 −2
Original line number Diff line number Diff line
@@ -569,7 +569,8 @@ static int cxl_add_chardev(struct cxl_afu *afu, dev_t devt, struct cdev *cdev, 
	int rc;



	cdev_init(cdev, fops);

	if ((rc = cdev_add(cdev, devt, 1))) {

	rc = cdev_add(cdev, devt, 1);

	if (rc) {

		dev_err(&afu->dev, "Unable to add %s chardev: %i\n", desc, rc);

		return rc;

	}
@@ -577,8 +578,8 @@ static int cxl_add_chardev(struct cxl_afu *afu, dev_t devt, struct cdev *cdev, 
	dev = device_create(cxl_class, &afu->dev, devt, afu,

			"afu%i.%i%s", afu->adapter->adapter_num, afu->slice, postfix);

	if (IS_ERR(dev)) {

		dev_err(&afu->dev, "Unable to create %s chardev in sysfs: %i\n", desc, rc);

		rc = PTR_ERR(dev);

		dev_err(&afu->dev, "Unable to create %s chardev in sysfs: %i\n", desc, rc);

		goto err;

	}