Unverified Commit da8b132d authored Jan 07, 2025 by openeuler-ci-bot Committed by Gitee Jan 07, 2025

!14608 scsi: qla2xxx: Fix use after free on unload

Merge Pull Request from: @ci-robot 
 
PR sync from: Yu Kuai <yukuai3@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/NSSBUIVCQEGY2SXQZM5D5NSCQ3OJHLU3/ 
 
https://gitee.com/src-openeuler/kernel/issues/IBEAOL 
 
Link:https://gitee.com/openeuler/kernel/pulls/14608

 

Reviewed-by: Zhang Peng <zhangpeng362@huawei.com>
Signed-off-by: Zhang Peng <zhangpeng362@huawei.com>

parents 6e98ebf5 7f96c795

drivers/scsi/qla2xxx/qla_os.c

+8 −7

Original line number	Diff line number	Diff line
		@@ -6899,12 +6899,15 @@ qla2x00_do_dpc(void *data)
		set_user_nice(current, MIN_NICE);

		set_current_state(TASK_INTERRUPTIBLE);
		while (!kthread_should_stop()) {
		while (1) {
		ql_dbg(ql_dbg_dpc, base_vha, 0x4000,
		"DPC handler sleeping.\n");

		schedule();

		if (kthread_should_stop())
		break;

		if (test_and_clear_bit(DO_EEH_RECOVERY, &base_vha->dpc_flags))
		qla_pci_set_eeh_busy(base_vha);

		@@ -6917,15 +6920,16 @@ qla2x00_do_dpc(void *data)
		goto end_loop;
		}

		if (test_bit(UNLOADING, &base_vha->dpc_flags))
		/* don't do any work. Wait to be terminated by kthread_stop */
		goto end_loop;

		ha->dpc_active = 1;

		ql_dbg(ql_dbg_dpc + ql_dbg_verbose, base_vha, 0x4001,
		"DPC handler waking up, dpc_flags=0x%lx.\n",
		base_vha->dpc_flags);

		if (test_bit(UNLOADING, &base_vha->dpc_flags))
		break;

		if (IS_P3P_TYPE(ha)) {
		if (IS_QLA8044(ha)) {
		if (test_and_clear_bit(ISP_UNRECOVERABLE,
		@@ -7238,9 +7242,6 @@ qla2x00_do_dpc(void *data)
		*/
		ha->dpc_active = 0;

		/* Cleanup any residual CTX SRBs. */
		qla2x00_abort_all_cmds(base_vha, DID_NO_CONNECT << 16);

		return 0;
		}