Commit da844beb authored by Vladimir Murzin's avatar Vladimir Murzin Committed by Will Deacon
Browse files

arm64: cpufeature: Account min_field_value when cheking secondaries for PAuth 



In case, both boot_val and sec_val have value below min_field_value we
would wrongly report that address authentication is supported. It is
not a big issue because we enable address authentication based on boot
cpu (and check there is correct).

Signed-off-by: default avatarVladimir Murzin <vladimir.murzin@arm.com>
Acked-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220224124952.119612-2-vladimir.murzin@arm.com


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent dfd42fac

arch/arm64/kernel/cpufeature.c

+1 −1
Original line number Diff line number Diff line
@@ -1829,7 +1829,7 @@ static bool has_address_auth_cpucap(const struct arm64_cpu_capabilities *entry, 
	/* Now check for the secondary CPUs with SCOPE_LOCAL_CPU scope */

	sec_val = cpuid_feature_extract_field(__read_sysreg_by_encoding(entry->sys_reg),

					      entry->field_pos, entry->sign);

	return sec_val == boot_val;

	return (sec_val >= entry->min_field_value) && (sec_val == boot_val);

}



static bool has_address_auth_metacap(const struct arm64_cpu_capabilities *entry,