Commit da8269a3 authored by Anand Jain's avatar Anand Jain Committed by David Sterba
Browse files

btrfs: avoid reusing return variable in nested block in btrfs_lookup_bio_sums 



The function btrfs_lookup_bio_sums() and a nested if statement declare
ret respectively as blk_status_t and int.

There is no need to store the return value of
search_file_offset_in_bio() to ret as this is a one-time call.

Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAnand Jain <anand.jain@oracle.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent fa13661c

fs/btrfs/file-item.c

+4 −5
Original line number Diff line number Diff line
@@ -494,12 +494,11 @@ blk_status_t btrfs_lookup_bio_sums(struct btrfs_bio *bbio) 
			if (inode->root->root_key.objectid ==

			    BTRFS_DATA_RELOC_TREE_OBJECTID) {

				u64 file_offset;

				int ret;



				ret = search_file_offset_in_bio(bio,

				if (search_file_offset_in_bio(bio,

							      &inode->vfs_inode,

						cur_disk_bytenr, &file_offset);

				if (ret)

							      cur_disk_bytenr,

							      &file_offset))

					set_extent_bits(io_tree, file_offset,

						file_offset + sectorsize - 1,

						EXTENT_NODATASUM);