Commit da791bac authored by Wong Vee Khee's avatar Wong Vee Khee Committed by Jakub Kicinski
Browse files

net: stmmac: remove redunctant disable xPCS EEE call 



Disable is done in stmmac_init_eee() on the event of MAC link down.
Since setting enable/disable EEE via ethtool will eventually trigger
a MAC down, removing this redunctant call in stmmac_ethtool.c to avoid
calling xpcs_config_eee() twice.

Fixes: d4aeaed8 ("net: stmmac: trigger PCS EEE to turn off on link down")
Signed-off-by: default avatarWong Vee Khee <vee.khee.wong@linux.intel.com>
Link: https://lore.kernel.org/r/20220715122402.1017470-1-vee.khee.wong@linux.intel.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 49a2f5c8

drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c

+0 −8
Original line number Diff line number Diff line
@@ -803,14 +803,6 @@ static int stmmac_ethtool_op_set_eee(struct net_device *dev, 
		netdev_warn(priv->dev,

			    "Setting EEE tx-lpi is not supported\n");



	if (priv->hw->xpcs) {

		ret = xpcs_config_eee(priv->hw->xpcs,

				      priv->plat->mult_fact_100ns,

				      edata->eee_enabled);

		if (ret)

			return ret;

	}



	if (!edata->eee_enabled)

		stmmac_disable_eee_mode(priv);