Unverified Commit da7260cc authored by Codrin Ciubotariu's avatar Codrin Ciubotariu Committed by Mark Brown
Browse files

ASoC: codecs: ad193x: Fix memory corruption on BE 64b systems 



Since change_bit() requires unsigned long*, making this cast on an
unsigned int variable will change a wrong bit on BE platforms, causing
memory corruption. Replace this function with a simple XOR.

Fixes: 90f6e680 ("ASoC: codecs: ad193x: Fix frame polarity for DSP_A format")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarCodrin Ciubotariu <codrin.ciubotariu@microchip.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ceaea851

sound/soc/codecs/ad193x.c

+2 −4
Original line number Diff line number Diff line
@@ -241,10 +241,8 @@ static int ad193x_set_dai_fmt(struct snd_soc_dai *codec_dai, 
	}



	/* For DSP_*, LRCLK's polarity must be inverted */

	if (fmt & SND_SOC_DAIFMT_DSP_A) {

		change_bit(ffs(AD193X_DAC_LEFT_HIGH) - 1,

			   (unsigned long *)&dac_fmt);

	}

	if (fmt & SND_SOC_DAIFMT_DSP_A)

		dac_fmt ^= AD193X_DAC_LEFT_HIGH;



	switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {

	case SND_SOC_DAIFMT_CBM_CFM: /* codec clk & frm master */