Commit da62908e authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Hans de Goede
Browse files

platform/x86: think-lmi: Properly interpret return value of tlmi_setting 



The return value of tlmi_settings() is an errorcode, not an acpi_status.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20230312-think-lmi-status-v1-1-4e9f36322cc4@weissschuh.net


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 8496baca

drivers/platform/x86/think-lmi.c

+2 −3
Original line number Diff line number Diff line
@@ -1353,7 +1353,6 @@ static struct tlmi_pwd_setting *tlmi_create_auth(const char *pwd_type, 


static int tlmi_analyze(void)

{

	acpi_status status;

	int i, ret;



	if (wmi_has_guid(LENOVO_SET_BIOS_SETTINGS_GUID) &&
@@ -1390,8 +1389,8 @@ static int tlmi_analyze(void) 
		char *p;



		tlmi_priv.setting[i] = NULL;

		status = tlmi_setting(i, &item, LENOVO_BIOS_SETTING_GUID);

		if (ACPI_FAILURE(status))

		ret = tlmi_setting(i, &item, LENOVO_BIOS_SETTING_GUID);

		if (ret)

			break;

		if (!item)

			break;