Commit da4089b7 authored by Zqiang's avatar Zqiang Committed by Xiongfeng Wang
Browse files

smp: Add missing destroy_work_on_stack() call in smp_call_on_cpu() 

stable inclusion
from stable-v4.19.322
commit 2d6a7a1ee3862d129c0e0fbd3cc147e185a379dc
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IAYQRI
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=2d6a7a1ee3862d129c0e0fbd3cc147e185a379dc



--------------------------------

[ Upstream commit 77aeb1b685f9db73d276bad4bb30d48505a6fd23 ]

For CONFIG_DEBUG_OBJECTS_WORK=y kernels sscs.work defined by
INIT_WORK_ONSTACK() is initialized by debug_object_init_on_stack() for
the debug check in __init_work() to work correctly.

But this lacks the counterpart to remove the tracked object from debug
objects again, which will cause a debug object warning once the stack is
freed.

Add the missing destroy_work_on_stack() invocation to cure that.

[ tglx: Massaged changelog ]

Signed-off-by: default avatarZqiang <qiang.zhang1211@gmail.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Tested-by: default avatarPaul E. McKenney <paulmck@kernel.org>
Link: https://lore.kernel.org/r/20240704065213.13559-1-qiang.zhang1211@gmail.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarXiongfeng Wang <wangxiongfeng2@huawei.com>
parent 5714ea88

kernel/smp.c

+1 −0
Original line number Diff line number Diff line
@@ -791,6 +791,7 @@ int smp_call_on_cpu(unsigned int cpu, int (*func)(void *), void *par, bool phys) 


	queue_work_on(cpu, system_wq, &sscs.work);

	wait_for_completion(&sscs.done);

	destroy_work_on_stack(&sscs.work);



	return sscs.ret;

}