Commit da3e5f66 authored by Yuan Can's avatar Yuan Can Committed by dinglongwei
Browse files

igb: Fix potential invalid memory access in igb_init_module() 

stable inclusion
from stable-v6.6.66
commit f309733a8c9da7d4266a8a3755020b738a570cae
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IBJCGB
CVE: CVE-2024-52332

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=f309733a8c9da7d4266a8a3755020b738a570cae



--------------------------------

[ Upstream commit 0566f83d206c7a864abcd741fe39d6e0ae5eef29 ]

The pci_register_driver() can fail and when this happened, the dca_notifier
needs to be unregistered, otherwise the dca_notifier can be called when
igb fails to install, resulting to invalid memory access.

Fixes: bbd98fe4 ("igb: Fix DCA errors and do not use context index for 82576")
Signed-off-by: default avatarYuan Can <yuancan@huawei.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarZhangPeng <zhangpeng362@huawei.com>
Signed-off-by: default avatardinglongwei <dinglongwei1@huawei.com>
parent 6b6d5871

drivers/net/ethernet/intel/igb/igb_main.c

+4 −0
Original line number Diff line number Diff line
@@ -665,6 +665,10 @@ static int __init igb_init_module(void) 
	dca_register_notify(&dca_notifier);

#endif

	ret = pci_register_driver(&igb_driver);

#ifdef CONFIG_IGB_DCA

	if (ret)

		dca_unregister_notify(&dca_notifier);

#endif

	return ret;

}