Commit da30a34a authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Rafael J. Wysocki
Browse files

ACPI: SPCR: Prefix error messages with FW_BUG 



The table values that are not defined in the specification are
considered non-fatal errors in the code.

However, they are firmware bugs, so point this out in the messages by
prefixing them with FW_BUG.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 91d7b60a

drivers/acpi/spcr.c

+2 −2
Original line number Diff line number Diff line
@@ -110,12 +110,12 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console) 
		u32 bit_width = table->serial_port.access_width;



		if (bit_width > ACPI_ACCESS_BIT_MAX) {

			pr_err("Unacceptable wide SPCR Access Width.  Defaulting to byte size\n");

			pr_err(FW_BUG "Unacceptable wide SPCR Access Width. Defaulting to byte size\n");

			bit_width = ACPI_ACCESS_BIT_DEFAULT;

		}

		switch (ACPI_ACCESS_BIT_WIDTH((bit_width))) {

		default:

			pr_err("Unexpected SPCR Access Width.  Defaulting to byte size\n");

			pr_err(FW_BUG "Unexpected SPCR Access Width. Defaulting to byte size\n");

			fallthrough;

		case 8:

			iotype = "mmio";