Commit da2edb3e authored Apr 21, 2023 by Dan Carpenter Committed by Stephen Boyd Jun 14, 2023

clk: bcm: rpi: Fix off by one in raspberrypi_discover_clocks()



Smatch detected an off by one in this code:
    drivers/clk/bcm/clk-raspberrypi.c:374 raspberrypi_discover_clocks()
    error: buffer overflow 'data->hws' 16 <= 16

The data->hws[] array has RPI_FIRMWARE_NUM_CLK_ID elements so the >
comparison needs to changed to >=.

Fixes: 12c90f3f ("clk: bcm: rpi: Add variant structure")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/5a850b08-d2f5-4794-aceb-a6b468965139@kili.mountain


Reviewed-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent a7a0c7d5

drivers/clk/bcm/clk-raspberrypi.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -356,9 +356,9 @@ static int raspberrypi_discover_clocks(struct raspberrypi_clk *rpi,
		while (clks->id) {
		struct raspberrypi_clk_variant *variant;

		if (clks->id > RPI_FIRMWARE_NUM_CLK_ID) {
		if (clks->id >= RPI_FIRMWARE_NUM_CLK_ID) {
		dev_err(rpi->dev, "Unknown clock id: %u (max: %u)\n",
		clks->id, RPI_FIRMWARE_NUM_CLK_ID);
		clks->id, RPI_FIRMWARE_NUM_CLK_ID - 1);
		return -EINVAL;
		}