Commit da2c9ced authored by Colin Ian King's avatar Colin Ian King Committed by Kalle Valo
Browse files

mwifiex: make arrays static const, makes object smaller 



Don't populate the arrays wpa_oui and wps_oui on the stack but
instead them static const. Makes the object code smaller by 63 bytes:

Before:
   text   data  bss     dec    hex filename
  29453   5451   64   34968   8898 .../wireless/marvell/mwifiex/sta_ioctl.o

After:
   text	  data  bss     dec    hex filename
  29356	  5611   64   35031   88d7 ../wireless/marvell/mwifiex/sta_ioctl.o

(gcc version 10.3.0)

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210819121651.7566-1-colin.king@canonical.com
parent 090f2c5d

drivers/net/wireless/marvell/mwifiex/sta_ioctl.c

+2 −2
Original line number Diff line number Diff line
@@ -1325,8 +1325,8 @@ mwifiex_set_gen_ie_helper(struct mwifiex_private *priv, u8 *ie_data_ptr, 
			  u16 ie_len)

{

	struct ieee_types_vendor_header *pvendor_ie;

	const u8 wpa_oui[] = { 0x00, 0x50, 0xf2, 0x01 };

	const u8 wps_oui[] = { 0x00, 0x50, 0xf2, 0x04 };

	static const u8 wpa_oui[] = { 0x00, 0x50, 0xf2, 0x01 };

	static const u8 wps_oui[] = { 0x00, 0x50, 0xf2, 0x04 };

	u16 unparsed_len = ie_len, cur_ie_len;



	/* If the passed length is zero, reset the buffer */