Commit da1a039b authored by Vinay Kumar Yadav's avatar Vinay Kumar Yadav Committed by Jakub Kicinski
Browse files

chelsio/chtls: fix writing freed memory



When chtls_sock *csk is freed, same memory can be allocated
to different csk in chtls_sock_create().
csk->cdev = NULL; statement might ends up modifying wrong
csk, eventually causing kernel panic.
removing (csk->cdev = NULL) statement as it is not required.

Fixes: 3a0a9783 ("crypto/chtls: Fix chtls crash in connection cleanup")
Signed-off-by: default avatarVinay Kumar Yadav <vinay.yadav@chelsio.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8580a61a
Loading
Loading
Loading
Loading
+0 −1
Original line number Diff line number Diff line
@@ -483,7 +483,6 @@ void chtls_destroy_sock(struct sock *sk)
	chtls_purge_write_queue(sk);
	free_tls_keyid(sk);
	kref_put(&csk->kref, chtls_sock_release);
	csk->cdev = NULL;
	if (sk->sk_family == AF_INET)
		sk->sk_prot = &tcp_prot;
#if IS_ENABLED(CONFIG_IPV6)