Commit da0ba0cc authored by Dongliang Mu's avatar Dongliang Mu Committed by Hans de Goede
Browse files

platform/x86/intel: vsec: Fix a memory leak in intel_vsec_add_aux 



The first error handling code in intel_vsec_add_aux misses the
deallocation of intel_vsec_dev->resource.

Fix this by adding kfree(intel_vsec_dev->resource) in the error handling
code.

Reviewed-by: default avatarDavid E. Box <david.e.box@linux.intel.com>
Signed-off-by: default avatarDongliang Mu <dzm91@hust.edu.cn>
Link: https://lore.kernel.org/r/20230309040107.534716-4-dzm91@hust.edu.cn


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 1a0009ab

drivers/platform/x86/intel/vsec.c

+1 −0
Original line number Diff line number Diff line
@@ -154,6 +154,7 @@ int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent, 
	ret = ida_alloc(intel_vsec_dev->ida, GFP_KERNEL);

	mutex_unlock(&vsec_ida_lock);

	if (ret < 0) {

		kfree(intel_vsec_dev->resource);

		kfree(intel_vsec_dev);

		return ret;

	}