Commit da0729e8 authored by Shannon Nelson's avatar Shannon Nelson Committed by David S. Miller
Browse files

ionic: simplify returns in devlink info 



There is no need for a goto in this bit of code.

Signed-off-by: default avatarShannon Nelson <snelson@pensando.io>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent df428e40

drivers/net/ethernet/pensando/ionic/ionic_devlink.c

+4 −5
Original line number Diff line number Diff line
@@ -19,31 +19,30 @@ static int ionic_dl_info_get(struct devlink *dl, struct devlink_info_req *req, 


	err = devlink_info_driver_name_put(req, IONIC_DRV_NAME);

	if (err)

		goto info_out;

		return err;



	err = devlink_info_version_running_put(req,

					       DEVLINK_INFO_VERSION_GENERIC_FW,

					       idev->dev_info.fw_version);

	if (err)

		goto info_out;

		return err;



	snprintf(buf, sizeof(buf), "0x%x", idev->dev_info.asic_type);

	err = devlink_info_version_fixed_put(req,

					     DEVLINK_INFO_VERSION_GENERIC_ASIC_ID,

					     buf);

	if (err)

		goto info_out;

		return err;



	snprintf(buf, sizeof(buf), "0x%x", idev->dev_info.asic_rev);

	err = devlink_info_version_fixed_put(req,

					     DEVLINK_INFO_VERSION_GENERIC_ASIC_REV,

					     buf);

	if (err)

		goto info_out;

		return err;



	err = devlink_info_serial_number_put(req, idev->dev_info.serial_num);



info_out:

	return err;

}