Commit da0342a3 authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Christoph Hellwig
Browse files

nvmet-auth: add missing goto in nvmet_setup_auth() 



There's a goto missing in nvmet_setup_auth(), causing a kernel oops
when nvme_auth_extract_key() fails.

Reported-by: default avatarTal Lossos <tallossos@gmail.com>
Signed-off-by: default avatarHannes Reinecke <hare@suse.de>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 200dccd0

drivers/nvme/target/auth.c

+1 −0
Original line number Diff line number Diff line
@@ -196,6 +196,7 @@ int nvmet_setup_auth(struct nvmet_ctrl *ctrl) 
	if (IS_ERR(ctrl->ctrl_key)) {

		ret = PTR_ERR(ctrl->ctrl_key);

		ctrl->ctrl_key = NULL;

		goto out_free_hash;

	}

	pr_debug("%s: using ctrl hash %s key %*ph\n", __func__,

		 ctrl->ctrl_key->hash > 0 ?