Commit d9f74d98 authored by Dan Carpenter's avatar Dan Carpenter Committed by Hans de Goede
Browse files

tools/power/x86/intel-speed-select: Fix off by one check 



Change > MAX_DIE_PER_PACKAGE to >= MAX_DIE_PER_PACKAGE to prevent
accessing one element beyond the end of the array.

Fixes: 7fd786df ("tools/power/x86/intel-speed-select: OOB daemon mode")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 7a4a04f4

tools/power/x86/intel-speed-select/isst-daemon.c

+1 −1
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ void process_level_change(int cpu) 
	time_t tm;

	int ret;



	if (pkg_id >= MAX_PACKAGE_COUNT || die_id > MAX_DIE_PER_PACKAGE) {

	if (pkg_id >= MAX_PACKAGE_COUNT || die_id >= MAX_DIE_PER_PACKAGE) {

		debug_printf("Invalid package/die info for cpu:%d\n", cpu);

		return;

	}