Commit d9f12a3b authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Dmitry Torokhov
Browse files

Input: tps65219-pwrbutton - use regmap_set_bits() 



regmap_set_bits() is equivalent to regmap_update_bits() if mask == val.
The probe function uses regmap_clear_bits() to enable irqs, so
symmetrically make use of regmap_set_bits() to disable them. There is no
semantic difference.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarMarkus Schneider-Pargmann <msp@baylibre.com>
Link: https://lore.kernel.org/r/20230605161458.117361-2-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent ab892b7f

drivers/input/misc/tps65219-pwrbutton.c

+2 −3
Original line number Diff line number Diff line
@@ -123,8 +123,7 @@ static void tps65219_pb_remove(struct platform_device *pdev) 
	int ret;



	/* Disable interrupt for the pushbutton */

	ret = regmap_update_bits(tps->regmap, TPS65219_REG_MASK_CONFIG,

				 TPS65219_REG_MASK_INT_FOR_PB_MASK,

	ret = regmap_set_bits(tps->regmap, TPS65219_REG_MASK_CONFIG,

			      TPS65219_REG_MASK_INT_FOR_PB_MASK);

	if (ret)

		dev_warn(&pdev->dev, "Failed to disable irq (%pe)\n", ERR_PTR(ret));