Commit d9c8d4b2 authored by Barry Song's avatar Barry Song Committed by Vinod Koul
Browse files

dmaengine: hisi_dma: remove redundant irqsave and irqrestore in hardIRQ 



Running in hardIRQ, disabling IRQ is redundant since hardIRQ has disabled
IRQ. This patch removes the irqsave and irqstore to save some instruction
cycles.

Signed-off-by: default avatarBarry Song <song.bao.hua@hisilicon.com>
Acked-by: default avatarZhou Wang <wangzhou1@hisilicon.com>
Link: https://lore.kernel.org/r/20201027215252.25820-8-song.bao.hua@hisilicon.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 1ff20656

drivers/dma/hisi_dma.c

+2 −3
Original line number Diff line number Diff line
@@ -431,9 +431,8 @@ static irqreturn_t hisi_dma_irq(int irq, void *data) 
	struct hisi_dma_dev *hdma_dev = chan->hdma_dev;

	struct hisi_dma_desc *desc;

	struct hisi_dma_cqe *cqe;

	unsigned long flags;



	spin_lock_irqsave(&chan->vc.lock, flags);

	spin_lock(&chan->vc.lock);



	desc = chan->desc;

	cqe = chan->cq + chan->cq_head;
@@ -452,7 +451,7 @@ static irqreturn_t hisi_dma_irq(int irq, void *data) 
		chan->desc = NULL;

	}



	spin_unlock_irqrestore(&chan->vc.lock, flags);

	spin_unlock(&chan->vc.lock);



	return IRQ_HANDLED;

}