Commit d978b9cf authored by Quentin Perret's avatar Quentin Perret Committed by Marc Zyngier
Browse files

KVM: arm64: Remove hyp_pool pointer from struct hyp_page 



Each struct hyp_page currently contains a pointer to a hyp_pool struct
where the page should be freed if its refcount reaches 0. However, this
information can always be inferred from the context in the EL2 code, so
drop the pointer to save a few bytes in the vmemmap.

Signed-off-by: default avatarQuentin Perret <qperret@google.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210608114518.748712-6-qperret@google.com
parent 7c350ea3

arch/arm64/kvm/hyp/include/nvhe/gfp.h

+2 −2
Original line number Diff line number Diff line
@@ -24,8 +24,8 @@ struct hyp_pool { 


/* Allocation */

void *hyp_alloc_pages(struct hyp_pool *pool, unsigned int order);

void hyp_get_page(void *addr);

void hyp_put_page(void *addr);

void hyp_get_page(struct hyp_pool *pool, void *addr);

void hyp_put_page(struct hyp_pool *pool, void *addr);



/* Used pages cannot be freed */

int hyp_pool_init(struct hyp_pool *pool, u64 pfn, unsigned int nr_pages,

arch/arm64/kvm/hyp/include/nvhe/memory.h

+0 −2
Original line number Diff line number Diff line
@@ -7,11 +7,9 @@ 


#include <linux/types.h>



struct hyp_pool;

struct hyp_page {

	unsigned int refcount;

	unsigned int order;

	struct hyp_pool *pool;

};



extern u64 __hyp_vmemmap;

arch/arm64/kvm/hyp/nvhe/mem_protect.c

+12 −2
Original line number Diff line number Diff line
@@ -43,6 +43,16 @@ static void *host_s2_zalloc_page(void *pool) 
	return hyp_alloc_pages(pool, 0);

}



static void host_s2_get_page(void *addr)

{

	hyp_get_page(&host_s2_pool, addr);

}



static void host_s2_put_page(void *addr)

{

	hyp_put_page(&host_s2_pool, addr);

}



static int prepare_s2_pool(void *pgt_pool_base)

{

	unsigned long nr_pages, pfn;
@@ -60,8 +70,8 @@ static int prepare_s2_pool(void *pgt_pool_base) 
		.phys_to_virt = hyp_phys_to_virt,

		.virt_to_phys = hyp_virt_to_phys,

		.page_count = hyp_page_count,

		.get_page = hyp_get_page,

		.put_page = hyp_put_page,

		.get_page = host_s2_get_page,

		.put_page = host_s2_put_page,

	};



	return 0;

arch/arm64/kvm/hyp/nvhe/page_alloc.c

+2 −5
Original line number Diff line number Diff line
@@ -174,20 +174,18 @@ static void __hyp_put_page(struct hyp_pool *pool, struct hyp_page *p) 
 * section to guarantee transient states (e.g. a page with null refcount but

 * not yet attached to a free list) can't be observed by well-behaved readers.

 */

void hyp_put_page(void *addr)

void hyp_put_page(struct hyp_pool *pool, void *addr)

{

	struct hyp_page *p = hyp_virt_to_page(addr);

	struct hyp_pool *pool = hyp_page_to_pool(p);



	hyp_spin_lock(&pool->lock);

	__hyp_put_page(pool, p);

	hyp_spin_unlock(&pool->lock);

}



void hyp_get_page(void *addr)

void hyp_get_page(struct hyp_pool *pool, void *addr)

{

	struct hyp_page *p = hyp_virt_to_page(addr);

	struct hyp_pool *pool = hyp_page_to_pool(p);



	hyp_spin_lock(&pool->lock);

	hyp_page_ref_inc(p);
@@ -236,7 +234,6 @@ int hyp_pool_init(struct hyp_pool *pool, u64 pfn, unsigned int nr_pages, 
	/* Init the vmemmap portion */

	p = hyp_phys_to_page(phys);

	for (i = 0; i < nr_pages; i++) {

		p[i].pool = pool;

		p[i].order = 0;

		hyp_set_page_refcounted(&p[i]);

	}

arch/arm64/kvm/hyp/nvhe/setup.c

+12 −2
Original line number Diff line number Diff line
@@ -137,6 +137,16 @@ static void *hyp_zalloc_hyp_page(void *arg) 
	return hyp_alloc_pages(&hpool, 0);

}



static void hpool_get_page(void *addr)

{

	hyp_get_page(&hpool, addr);

}



static void hpool_put_page(void *addr)

{

	hyp_put_page(&hpool, addr);

}



void __noreturn __pkvm_init_finalise(void)

{

	struct kvm_host_data *host_data = this_cpu_ptr(&kvm_host_data);
@@ -160,8 +170,8 @@ void __noreturn __pkvm_init_finalise(void) 
		.zalloc_page = hyp_zalloc_hyp_page,

		.phys_to_virt = hyp_phys_to_virt,

		.virt_to_phys = hyp_virt_to_phys,

		.get_page = hyp_get_page,

		.put_page = hyp_put_page,

		.get_page = hpool_get_page,

		.put_page = hpool_put_page,

	};

	pkvm_pgtable.mm_ops = &pkvm_pgtable_mm_ops;