Unverified Commit d93ee84e authored by Ying Liu's avatar Ying Liu Committed by Mark Brown
Browse files

ASoC: tas5720: add missing unwind goto in tas5720_codec_probe 



Smatch complains that missing unwind goto in tas5720_codec_probe.

When tas5720 has an invalid devtype, it is expected to invoke
regulator_bulk_disable to handle the failure. But the default
option return an error code directly. Fix it by reusing the
probe_fail label.

Signed-off-by: default avatarYing Liu <lyre@hust.edu.cn>
Link: https://lore.kernel.org/r/20230411170912.1939906-1-lyre@hust.edu.cn


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ef0128af

sound/soc/codecs/tas5720.c

+2 −1
Original line number Diff line number Diff line
@@ -339,7 +339,8 @@ static int tas5720_codec_probe(struct snd_soc_component *component) 
		break;

	default:

		dev_err(component->dev, "unexpected private driver data\n");

		return -EINVAL;

		ret = -EINVAL;

		goto probe_fail;

	}



	if (device_id != expected_device_id)