Commit d8fc1c7c authored by Andrew Davis's avatar Andrew Davis Committed by Jens Wiklander
Browse files

tee: remove flags TEE_IOCTL_SHM_MAPPED and TEE_IOCTL_SHM_DMA_BUF 



These look to be leftover from an early edition of this driver. Userspace
does not need this information. Checking all users of this that I have
access to I have verified no one is using them.

They leak internal use flags out to userspace. Even more they are not
correct anymore after a45ea4ef. Lets drop these flags before
someone does try to use them for something and they become ABI.

Signed-off-by: default avatarAndrew Davis <afd@ti.com>
Acked-by: default avatarSumit Garg <sumit.garg@linaro.org>
Signed-off-by: default avatarJens Wiklander <jens.wiklander@linaro.org>
parent 66eb6df7

drivers/tee/tee_core.c

+0 −2
Original line number Diff line number Diff line
@@ -302,7 +302,6 @@ static int tee_ioctl_shm_alloc(struct tee_context *ctx, 
		return PTR_ERR(shm);



	data.id = shm->id;

	data.flags = shm->flags;

	data.size = shm->size;



	if (copy_to_user(udata, &data, sizeof(data)))
@@ -339,7 +338,6 @@ tee_ioctl_shm_register(struct tee_context *ctx, 
		return PTR_ERR(shm);



	data.id = shm->id;

	data.flags = shm->flags;

	data.length = shm->size;



	if (copy_to_user(udata, &data, sizeof(data)))

include/uapi/linux/tee.h

+0 −4
Original line number Diff line number Diff line
@@ -42,10 +42,6 @@ 
#define TEE_IOC_MAGIC	0xa4

#define TEE_IOC_BASE	0



/* Flags relating to shared memory */

#define TEE_IOCTL_SHM_MAPPED	0x1	/* memory mapped in normal world */

#define TEE_IOCTL_SHM_DMA_BUF	0x2	/* dma-buf handle on shared memory */



#define TEE_MAX_ARG_SIZE	1024



#define TEE_GEN_CAP_GP		(1 << 0)/* GlobalPlatform compliant TEE */