Commit d8f40f92 authored by Ignat Korchagin's avatar Ignat Korchagin Committed by Zhang Changzhong
Browse files

net: af_can: do not leave a dangling sk pointer in can_create() 

mainline inclusion
from mainline-v6.13-rc1
commit 811a7ca7320c062e15d0f5b171fe6ad8592d1434
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IBEANB
CVE: CVE-2024-56603

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=811a7ca7320c062e15d0f5b171fe6ad8592d1434



--------------------------------

On error can_create() frees the allocated sk object, but sock_init_data()
has already attached it to the provided sock object. This will leave a
dangling sk pointer in the sock object and may cause use-after-free later.

Signed-off-by: default avatarIgnat Korchagin <ignat@cloudflare.com>
Reviewed-by: default avatarVincent Mailhol <mailhol.vincent@wanadoo.fr>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
Link: https://patch.msgid.link/20241014153808.51894-5-ignat@cloudflare.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
parent ba3cb236

net/can/af_can.c

+1 −0
Original line number Diff line number Diff line
@@ -189,6 +189,7 @@ static int can_create(struct net *net, struct socket *sock, int protocol, 
		/* release sk on errors */

		sock_orphan(sk);

		sock_put(sk);

		sock->sk = NULL;

	}



 errout: