Commit d8dfab0f authored May 24, 2019 by Anson Huang Committed by Shawn Guo Jun 05, 2019

soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling



of_node_put() is called after of_match_node() successfully called,
then in the following error handling, of_node_put() is called again
which is unnecessary, this patch adjusts the location of of_node_put()
to avoid such scenario.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>

parent 15f5276a

drivers/soc/imx/soc-imx8.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -115,8 +115,6 @@ static int __init imx8_soc_init(void)
		if (!id)
		goto free_soc;

		of_node_put(root);

		data = id->data;
		if (data) {
		soc_dev_attr->soc_id = data->name;
		@@ -132,6 +130,8 @@ static int __init imx8_soc_init(void)
		if (IS_ERR(soc_dev))
		goto free_rev;

		of_node_put(root);

		return 0;

		free_rev: