Commit d8dc8720 authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Takashi Iwai
Browse files

ALSA: firewire-lib: fix uninitialized local variable 



The function local variable, curr_cycle_time is declared without
initialization. When tracepoints event is not probed, it looks to be
used as is. This commit fixes it. Fortunately, the value of local variable
is not used unless the event is probed, thus this commit is for better
coding.

Reported-by: default avatarDan Carpenter <error27@gmail.com>
Fixes: fef4e61b ("ALSA: firewire-lib: extend tracepoints event including CYCLE_TIME of 1394 OHCI")
Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20230130141532.102838-1-o-takashi@sakamocchi.jp


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent ba35c3a5

sound/firewire/amdtp-stream.c

+1 −1
Original line number Diff line number Diff line
@@ -910,7 +910,7 @@ static int generate_tx_packet_descs(struct amdtp_stream *s, struct pkt_desc *des 
	unsigned int dbc = s->data_block_counter;

	unsigned int packet_index = s->packet_index;

	unsigned int queue_size = s->queue_size;

	u32 curr_cycle_time;

	u32 curr_cycle_time = 0;

	int i;

	int err;