Commit d8b22831 authored by Szymon Heidrich's avatar Szymon Heidrich Committed by David S. Miller
Browse files

net: usb: smsc75xx: Limit packet length to skb->len 



Packet length retrieved from skb data may be larger than
the actual socket buffer length (up to 9026 bytes). In such
case the cloned skb passed up the network stack will leak
kernel memory contents.

Fixes: d0cad871 ("smsc75xx: SMSC LAN75xx USB gigabit ethernet adapter driver")
Signed-off-by: default avatarSzymon Heidrich <szymon.heidrich@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fd6ad75f

drivers/net/usb/smsc75xx.c

+2 −1
Original line number Diff line number Diff line
@@ -2212,7 +2212,8 @@ static int smsc75xx_rx_fixup(struct usbnet *dev, struct sk_buff *skb) 
				dev->net->stats.rx_frame_errors++;

		} else {

			/* MAX_SINGLE_PACKET_SIZE + 4(CRC) + 2(COE) + 4(Vlan) */

			if (unlikely(size > (MAX_SINGLE_PACKET_SIZE + ETH_HLEN + 12))) {

			if (unlikely(size > (MAX_SINGLE_PACKET_SIZE + ETH_HLEN + 12) ||

				     size > skb->len)) {

				netif_dbg(dev, rx_err, dev->net,

					  "size err rx_cmd_a=0x%08x\n",

					  rx_cmd_a);