Commit d8aeb44a authored by Jens Axboe's avatar Jens Axboe
Browse files

fs: add FMODE_DIO_PARALLEL_WRITE flag 



Some filesystems support multiple threads writing to the same file with
O_DIRECT without requiring exclusive access to it. io_uring can use this
hint to avoid serializing dio writes to this inode, instead allowing them
to run in parallel.

XFS and ext4 both fall into this category, so set the flag for both of
them.

Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 7e364e56

fs/ext4/file.c

+2 −1
Original line number Diff line number Diff line
@@ -899,7 +899,8 @@ static int ext4_file_open(struct inode *inode, struct file *filp) 
			return ret;

	}



	filp->f_mode |= FMODE_NOWAIT | FMODE_BUF_RASYNC;

	filp->f_mode |= FMODE_NOWAIT | FMODE_BUF_RASYNC |

			FMODE_DIO_PARALLEL_WRITE;

	return dquot_file_open(inode, filp);

}

fs/xfs/xfs_file.c

+2 −1
Original line number Diff line number Diff line
@@ -1171,7 +1171,8 @@ xfs_file_open( 
{

	if (xfs_is_shutdown(XFS_M(inode->i_sb)))

		return -EIO;

	file->f_mode |= FMODE_NOWAIT | FMODE_BUF_RASYNC | FMODE_BUF_WASYNC;

	file->f_mode |= FMODE_NOWAIT | FMODE_BUF_RASYNC | FMODE_BUF_WASYNC |

			FMODE_DIO_PARALLEL_WRITE;

	return generic_file_open(inode, file);

}

include/linux/fs.h

+3 −0
Original line number Diff line number Diff line
@@ -168,6 +168,9 @@ typedef int (dio_iodone_t)(struct kiocb *iocb, loff_t offset, 


#define	FMODE_NOREUSE		((__force fmode_t)0x800000)



/* File supports non-exclusive O_DIRECT writes from multiple threads */

#define FMODE_DIO_PARALLEL_WRITE	((__force fmode_t)0x1000000)



/* File was opened by fanotify and shouldn't generate fanotify events */

#define FMODE_NONOTIFY		((__force fmode_t)0x4000000)