Commit d8898ee5 authored by Stefan Haberland's avatar Stefan Haberland Committed by Jens Axboe
Browse files

s390/dasd: fix hanging blockdevice after request requeue 



The DASD driver does not kick the requeue list when requeuing IO requests
to the blocklayer. This might lead to hanging blockdevice when there is
no other trigger for this.

Fix by automatically kick the requeue list when requeuing DASD requests
to the blocklayer.

Fixes: e443343e ("s390/dasd: blk-mq conversion")
CC: stable@vger.kernel.org # 4.14+
Signed-off-by: default avatarStefan Haberland <sth@linux.ibm.com>
Reviewed-by: default avatarJan Hoeppner <hoeppner@linux.ibm.com>
Reviewed-by: default avatarHalil Pasic <pasic@linux.ibm.com>
Link: https://lore.kernel.org/r/20230405142017.2446986-8-sth@linux.ibm.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent d9ee2bee

drivers/s390/block/dasd.c

+1 −1
Original line number Diff line number Diff line
@@ -2953,7 +2953,7 @@ static int _dasd_requeue_request(struct dasd_ccw_req *cqr) 
		return 0;

	spin_lock_irq(&cqr->dq->lock);

	req = (struct request *) cqr->callback_data;

	blk_mq_requeue_request(req, false);

	blk_mq_requeue_request(req, true);

	spin_unlock_irq(&cqr->dq->lock);



	return 0;