Commit d855fe2e authored by Oliver Neukum's avatar Oliver Neukum Committed by Greg Kroah-Hartman
Browse files

usb: cdc-wdm: Fix race between disconnect and debug messages 



dev_dbg() and dev_err() cannot be used to report failures
that may have been caused by a device's removal

Signed-off-by: default avatarOliver Neukum <neukum@b1-systems.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 922a5ead

drivers/usb/class/cdc-wdm.c

+0 −5
Original line number Diff line number Diff line
@@ -435,11 +435,8 @@ static ssize_t wdm_read 
		spin_lock_irq(&desc->iuspin);



		if (desc->rerr) { /* read completed, error happened */

			int t = desc->rerr;

			desc->rerr = 0;

			spin_unlock_irq(&desc->iuspin);

			dev_err(&desc->intf->dev,

				"reading had resulted in %d\n", t);

			rv = -EIO;

			goto err;

		}
@@ -477,8 +474,6 @@ static ssize_t wdm_read 


err:

	mutex_unlock(&desc->lock);

	if (rv < 0 && rv != -EAGAIN)

		dev_err(&desc->intf->dev, "wdm_read: exit error\n");

	return rv;

}