Commit d853f1d3 authored Sep 17, 2021 by Colin Ian King Committed by David S. Miller Sep 17, 2021

octeontx2-af: Fix uninitialized variable val



In the case where the condition !is_rvu_otx2(rvu) is false variable
val is not initialized and can contain a garbage value. Fix this by
initializing val to zero and bit-wise or'ing in BIT_ULL(51) to val
for the true condition case of !is_rvu_otx2(rvu).

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 4b5a3ab1 ("octeontx2-af: Hardware configuration for inline IPsec")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6042d434

drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -4596,9 +4596,10 @@ static void nix_inline_ipsec_cfg(struct rvu rvu, struct nix_inline_ipsec_cfg r

		cpt_idx = (blkaddr == BLKADDR_NIX0) ? 0 : 1;
		if (req->enable) {
		val = 0;
		/* Enable context prefetching */
		if (!is_rvu_otx2(rvu))
		val = BIT_ULL(51);
		val \|= BIT_ULL(51);

		/* Set OPCODE and EGRP */
		val \|= FIELD_PREP(IPSEC_GEN_CFG_EGRP, req->gen_cfg.egrp);