Commit d836715f authored by Jialin Zhang's avatar Jialin Zhang Committed by Jonathan Cameron
Browse files

iio: adc: rzg2l_adc: add missing fwnode_handle_put() in rzg2l_adc_parse_properties() 



fwnode_handle_put() should be used when terminating
device_for_each_child_node() iteration with break or return to prevent
stale device node references from being left behind.

Fixes: d484c21b ("iio: adc: Add driver for Renesas RZ/G2L A/D converter")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarJialin Zhang <zhangjialin11@huawei.com>
Reviewed-by: default avatarLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20220517033526.2035735-1-zhangjialin11@huawei.com


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 78601726

drivers/iio/adc/rzg2l_adc.c

+6 −2
Original line number Diff line number Diff line
@@ -334,11 +334,15 @@ static int rzg2l_adc_parse_properties(struct platform_device *pdev, struct rzg2l 
	i = 0;

	device_for_each_child_node(&pdev->dev, fwnode) {

		ret = fwnode_property_read_u32(fwnode, "reg", &channel);

		if (ret)

		if (ret) {

			fwnode_handle_put(fwnode);

			return ret;

		}



		if (channel >= RZG2L_ADC_MAX_CHANNELS)

		if (channel >= RZG2L_ADC_MAX_CHANNELS) {

			fwnode_handle_put(fwnode);

			return -EINVAL;

		}



		chan_array[i].type = IIO_VOLTAGE;

		chan_array[i].indexed = 1;