Commit d818cc76 authored by Zqiang's avatar Zqiang Committed by Paul E. McKenney
Browse files

kasan: Record work creation stack trace with interrupts enabled 



Recording the work creation stack trace for KASAN reports in
call_rcu() is expensive, due to unwinding the stack, but also
due to acquiring depot_lock inside stackdepot (which may be contended).
Because calling kasan_record_aux_stack_noalloc() does not require
interrupts to already be disabled, this may unnecessarily extend
the time with interrupts disabled.

Therefore, move calling kasan_record_aux_stack() before the section
with interrupts disabled.

Acked-by: default avatarMarco Elver <elver@google.com>
Signed-off-by: default avatarZqiang <qiang1.zhang@intel.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
parent 1fe09ebe

kernel/rcu/tree.c

+1 −1
Original line number Diff line number Diff line
@@ -3060,8 +3060,8 @@ void call_rcu(struct rcu_head *head, rcu_callback_t func) 
	}

	head->func = func;

	head->next = NULL;

	local_irq_save(flags);

	kasan_record_aux_stack_noalloc(head);

	local_irq_save(flags);

	rdp = this_cpu_ptr(&rcu_data);



	/* Add the callback to our list. */