Commit d7ef887f authored by Xiaojian Du's avatar Xiaojian Du Committed by Alex Deucher
Browse files

drm/amd/pm: make the error log more clear for fine grain tuning function 



This patch is to make the error log more clear for fine grain tuning
function, it covers Raven/Raven2/Picasso/Renoir/Vangogh.
The fine grain tuning function uses the sysfs file -- pp_od_clk_voltage,
but only when another sysfs file -- power_dpm_force_performance_level is
switched to "manual" mode, it is allowed to access "pp_od_clk_voltage".

Signed-off-by: default avatarXiaojian Du <Xiaojian.Du@amd.com>
Acked-by: default avatarHuang Rui <ray.huang@amd.com>
Acked-by: default avatarKevin Wang <kevin1.wang@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 006cc1a2

drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c

+1 −1
Original line number Diff line number Diff line
@@ -1487,7 +1487,7 @@ static int smu10_set_fine_grain_clk_vol(struct pp_hwmgr *hwmgr, 
	}



	if (!smu10_data->fine_grain_enabled) {

		pr_err("Fine grain not started\n");

		pr_err("pp_od_clk_voltage is not accessible if power_dpm_force_perfomance_level is not in manual mode!\n");

		return -EINVAL;

	}

drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c

+2 −1
Original line number Diff line number Diff line
@@ -1461,7 +1461,8 @@ static int vangogh_od_edit_dpm_table(struct smu_context *smu, enum PP_OD_DPM_TAB 
	struct smu_dpm_context *smu_dpm_ctx = &(smu->smu_dpm);



	if (!(smu_dpm_ctx->dpm_level == AMD_DPM_FORCED_LEVEL_MANUAL)) {

		dev_warn(smu->adev->dev, "Fine grain is not enabled!\n");

		dev_warn(smu->adev->dev,

			"pp_od_clk_voltage is not accessible if power_dpm_force_perfomance_level is not in manual mode!\n");

		return -EINVAL;

	}

drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c

+2 −1
Original line number Diff line number Diff line
@@ -350,7 +350,8 @@ static int renoir_od_edit_dpm_table(struct smu_context *smu, 
	struct smu_dpm_context *smu_dpm_ctx = &(smu->smu_dpm);



	if (!(smu_dpm_ctx->dpm_level == AMD_DPM_FORCED_LEVEL_MANUAL)) {

		dev_warn(smu->adev->dev, "Fine grain is not enabled!\n");

		dev_warn(smu->adev->dev,

			"pp_od_clk_voltage is not accessible if power_dpm_force_perfomance_level is not in manual mode!\n");

		return -EINVAL;

	}