Commit d7bce85a authored by Michael S. Tsirkin's avatar Michael S. Tsirkin
Browse files

virtio_pci_modern: correct sparse tags for notify 



When switching virtio_pci_modern to use a helper for mappings we lost an
__iomem tag. Restore it.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Fixes: 9e3bb9b7 ("virtio_pci_modern: introduce helper to map vq notify area")
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 0f8a0b0b

drivers/virtio/virtio_pci_modern_dev.c

+4 −5
Original line number Diff line number Diff line
@@ -605,7 +605,7 @@ static u16 vp_modern_get_queue_notify_off(struct virtio_pci_modern_device *mdev, 
 *

 * Returns the address of the notification area

 */

void *vp_modern_map_vq_notify(struct virtio_pci_modern_device *mdev,

void __iomem *vp_modern_map_vq_notify(struct virtio_pci_modern_device *mdev,

				      u16 index, resource_size_t *pa)

{

	u16 off = vp_modern_get_queue_notify_off(mdev, index);
@@ -624,10 +624,9 @@ void *vp_modern_map_vq_notify(struct virtio_pci_modern_device *mdev, 
		if (pa)

			*pa = mdev->notify_pa +

			      off * mdev->notify_offset_multiplier;

		return (void __force *)mdev->notify_base +

			off * mdev->notify_offset_multiplier;

		return mdev->notify_base + off * mdev->notify_offset_multiplier;

	} else {

		return (void __force *)vp_modern_map_capability(mdev,

		return vp_modern_map_capability(mdev,

				       mdev->notify_map_cap, 2, 2,

				       off * mdev->notify_offset_multiplier, 2,

				       NULL, pa);

include/linux/virtio_pci_modern.h

+2 −2
Original line number Diff line number Diff line
@@ -101,7 +101,7 @@ void vp_modern_set_queue_size(struct virtio_pci_modern_device *mdev, 
u16 vp_modern_get_queue_size(struct virtio_pci_modern_device *mdev,

			     u16 idx);

u16 vp_modern_get_num_queues(struct virtio_pci_modern_device *mdev);

void *vp_modern_map_vq_notify(struct virtio_pci_modern_device *mdev,

void __iomem * vp_modern_map_vq_notify(struct virtio_pci_modern_device *mdev,

				       u16 index, resource_size_t *pa);

int vp_modern_probe(struct virtio_pci_modern_device *mdev);

void vp_modern_remove(struct virtio_pci_modern_device *mdev);