Commit d7b061b8 authored by Yunsheng Lin's avatar Yunsheng Lin Committed by Jakub Kicinski
Browse files

net: tso: inline tso_count_descs() 



tso_count_descs() is a small function doing simple calculation,
and tso_count_descs() is used in fast path, so inline it to
reduce the overhead of calls.

Signed-off-by: default avatarYunsheng Lin <linyunsheng@huawei.com>
Link: https://lore.kernel.org/r/20221212032426.16050-1-linyunsheng@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8f18655c

include/net/tso.h

+7 −1
Original line number Diff line number Diff line
@@ -2,6 +2,7 @@ 
#ifndef _TSO_H

#define _TSO_H



#include <linux/skbuff.h>

#include <net/ip.h>



#define TSO_HEADER_SIZE		256
@@ -16,7 +17,12 @@ struct tso_t { 
	u32	tcp_seq;

};



int tso_count_descs(const struct sk_buff *skb);

/* Calculate the worst case buffer count */

static inline int tso_count_descs(const struct sk_buff *skb)

{

	return skb_shinfo(skb)->gso_segs * 2 + skb_shinfo(skb)->nr_frags;

}



void tso_build_hdr(const struct sk_buff *skb, char *hdr, struct tso_t *tso,

		   int size, bool is_last);

void tso_build_data(const struct sk_buff *skb, struct tso_t *tso, int size);

net/core/tso.c

+0 −8
Original line number Diff line number Diff line
@@ -5,14 +5,6 @@ 
#include <net/tso.h>

#include <asm/unaligned.h>



/* Calculate expected number of TX descriptors */

int tso_count_descs(const struct sk_buff *skb)

{

	/* The Marvell Way */

	return skb_shinfo(skb)->gso_segs * 2 + skb_shinfo(skb)->nr_frags;

}

EXPORT_SYMBOL(tso_count_descs);



void tso_build_hdr(const struct sk_buff *skb, char *hdr, struct tso_t *tso,

		   int size, bool is_last)

{