Commit d7ac8dca authored by Keith Busch's avatar Keith Busch Committed by Christoph Hellwig
Browse files

nvme: quiet user passthrough command errors 



The driver is spamming the kernel logs for entirely harmless errors from
user space submitting unsupported commands. Just silence the errors.
The application has direct access to command status, so there's no need
to log these.

And since every passthrough command now uses the quiet flag, move the
setting to the common initializer.

Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
Reviewed-by: default avatarAlan Adamson <alan.adamson@oracle.com>
Reviewed-by: default avatarJens Axboe <axboe@kernel.dk>
Reviewed-by: default avatarKanchan Joshi <joshi.k@samsung.com>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: default avatarDaniel Wagner <dwagner@suse.de>
Tested-by: default avatarAlan Adamson <alan.adamson@oracle.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent f829230d

drivers/nvme/host/core.c

+1 −2
Original line number Diff line number Diff line
@@ -675,6 +675,7 @@ void nvme_init_request(struct request *req, struct nvme_command *cmd) 
	if (req->mq_hctx->type == HCTX_TYPE_POLL)

		req->cmd_flags |= REQ_POLLED;

	nvme_clear_nvme_request(req);

	req->rq_flags |= RQF_QUIET;

	memcpy(nvme_req(req)->cmd, cmd, sizeof(*cmd));

}

EXPORT_SYMBOL_GPL(nvme_init_request);
@@ -1037,7 +1038,6 @@ int __nvme_submit_sync_cmd(struct request_queue *q, struct nvme_command *cmd, 
			goto out;

	}



	req->rq_flags |= RQF_QUIET;

	ret = nvme_execute_rq(req, at_head);

	if (result && ret >= 0)

		*result = nvme_req(req)->result;
@@ -1227,7 +1227,6 @@ static void nvme_keep_alive_work(struct work_struct *work) 
	rq->timeout = ctrl->kato * HZ;

	rq->end_io = nvme_keep_alive_end_io;

	rq->end_io_data = ctrl;

	rq->rq_flags |= RQF_QUIET;

	blk_execute_rq_nowait(rq, false);

}

drivers/nvme/host/pci.c

+0 −2
Original line number Diff line number Diff line
@@ -1436,7 +1436,6 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req) 


	abort_req->end_io = abort_endio;

	abort_req->end_io_data = NULL;

	abort_req->rq_flags |= RQF_QUIET;

	blk_execute_rq_nowait(abort_req, false);



	/*
@@ -2490,7 +2489,6 @@ static int nvme_delete_queue(struct nvme_queue *nvmeq, u8 opcode) 
	req->end_io_data = nvmeq;



	init_completion(&nvmeq->delete_done);

	req->rq_flags |= RQF_QUIET;

	blk_execute_rq_nowait(req, false);

	return 0;

}