Commit d7ac8b1b authored by Akinobu Mita's avatar Akinobu Mita Committed by Mauro Carvalho Chehab
Browse files

media: ov7740: remove redundant V4L2_CTRL_FLAG_VOLATILE set 



If the v4l2 controls are set up for autofoo/foo-type handling by calling
v4l2_ctrl_auto_cluster() with the last set_volatile argument setting true,
each non-auto control doesn't need to be flagged V4L2_CTRL_FLAG_VOLATILE.

Cc: Wenyou Yang <wenyou.yang@microchip.com>
Cc: Eugen Hristev <eugen.hristev@microchip.com>
Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent eed6b2e7

drivers/media/i2c/ov7740.c

+0 −2
Original line number Diff line number Diff line
@@ -1012,8 +1012,6 @@ static int ov7740_init_controls(struct ov7740 *ov7740) 


	ov7740->gain = v4l2_ctrl_new_std(ctrl_hdlr, &ov7740_ctrl_ops,

				       V4L2_CID_GAIN, 0, 1023, 1, 500);

	if (ov7740->gain)

		ov7740->gain->flags |= V4L2_CTRL_FLAG_VOLATILE;



	ov7740->auto_gain = v4l2_ctrl_new_std(ctrl_hdlr, &ov7740_ctrl_ops,

					    V4L2_CID_AUTOGAIN, 0, 1, 1, 1);